Refine Sheet hit-test ordering and expand Sheet screenshot test by shai-almog · Pull Request #4505 · codenameone/CodenameOne

shai-almog · 2026-02-09T05:04:03Z

Motivation

Ensure native peer touch passthrough checks only consult Sheet visibility when a native PeerComponent is involved to minimize overhead and avoid unnecessary EDT interactions.
Provide a thread-safe, native-friendly way to determine visible Sheet bounds so native event paths can safely decide whether to deliver touches to peer components.
Improve the HelloCodenameOne screenshot test to exercise nested sheets and title-bar commands for better coverage of show/dismiss behavior.

Description

Added thread-safe sheet bounds tracking to Sheet with a private SheetBounds type, a volatile sheetBounds array, and helpers updateSheetBounds, removeSheetBounds, startTrackingBounds, stopTrackingBounds, and updateTrackedBounds to maintain a lightweight cache usable off the EDT, and exposed the query Sheet.isSheetVisibleAt(int x, int y).
Hooked tracking into the sheet lifecycle by calling startTrackingBounds() during show() and stopTrackingBounds() when a sheet is hidden, and by overriding setX, setY, setWidth, and setHeight to refresh tracked bounds when the sheet moves or resizes.
Changed native hit-test ordering to first detect whether the component at the touch location is a PeerComponent and only then consult Sheet.isSheetVisibleAt(...): updated touch logic in Ports/Android/src/com/codename1/impl/android/CodenameOneView.java and Ports/iOSPort/src/com/codename1/impl/ios/IOSImplementation.java to defer sheet checks until a peer is present.
Expanded the screenshot test SheetScreenshotTest (added under scripts/hellocodenameone) to create a parent and nested child sheet, add an extra command to the sheet title bar, and register the test in Cn1ssDeviceRunner so the device runner exercises nested sheet behavior.

Testing

No automated tests were executed as part of this change in this environment (no CI/build run was requested).

Codex Task

shai-almog · 2026-02-09T05:17:12Z

Compared 31 screenshots: 31 matched.

Native Android coverage

📊 Line coverage: 7.18% (3645/50732 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 5.61% (17917/319512), branch 2.71% (843/31069), complexity 3.33% (989/29695), method 5.86% (811/13829), class 9.58% (175/1826)
- Lowest covered classes
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
  - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
  - kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
  - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered)
  - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
  - kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

📊 Line coverage: 7.18% (3645/50732 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 5.61% (17917/319512), branch 2.71% (843/31069), complexity 3.33% (989/29695), method 5.86% (811/13829), class 9.58% (175/1826)
- Lowest covered classes
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
  - kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
  - kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
  - kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered)
  - kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
  - org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
  - kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
  - kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

shai-almog · 2026-02-09T05:39:57Z

Compared 31 screenshots: 31 matched.
✅ Native Android screenshot tests passed.

Benchmark Results

VM Translation Time: 332 seconds
Compilation Time: 309 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	30456 ms
Extract Extensions	17 ms
Google Services Setup	2 ms
Scan Classes	1188 ms
Extract Libs	838 ms
Inject Build Hints	46 ms
Generate Unit Tests	2 ms
Generate Stubs	1014 ms
Compile Stubs	2084 ms
Generate Icons	1265 ms
Prepare ParparVM	299 ms
ParparVM Execution	179099 ms
Post-VM Setup	138 ms
CocoaPods	4526 ms
Finalize	22 ms
Total Time	220997 msMaven Overhead : 112000 ms
CocoaPods Install (Script)	2000 ms
Simulator Boot	114000 ms
Simulator Boot (Run)	1000 ms
App Install	15000 ms
App Launch	8000 ms
Test Execution	189000 ms

github-actions · 2026-02-09T05:50:48Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2300 total, 0 failed, 0 skipped
📊 Line coverage: 53.00% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.ui.Display$EdtException – 0.00%
  - com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
  - com.codename1.util.EasyThread$InQueueRunnable – 0.00%
  - com.codename1.components.FloatingActionButton$ReleaseActionListener – 0.00%
  - com.codename1.io.Oauth2$ShowAuthenticationActionListener – 0.00%
  - com.codename1.io.Oauth2$RefreshTokenActionListener – 0.00%
  - com.codename1.util.EasyThread$RunAndWaitRunnable – 0.00%
  - com.codename1.components.ToastBar$FlushAnimationCallback – 0.00%
  - com.codename1.ui.plaf.CSSBorder$ColorStop – 0.00%
  - com.codename1.ui.ElevationComparator – 0.00%

Static Analysis

SpotBugs [HTML preview] [Download]
- ❌ ByteCodeTranslator: 97 findings (High: 2, Normal: 68, Low: 27)
  - Top findings
    - High: com/codename1/tools/translator/BytecodeMethod.java:559 – Method com.codename1.tools.translator.BytecodeMethod.findWritableFields(Set) seems to be useless (rule: UC_USELESS_VOID_METHOD)
    - High: com/codename1/tools/translator/bytecodes/TryCatch.java:75 – Write to static field com.codename1.tools.translator.bytecodes.TryCatch.hasTryCatch from instance method com.codename1.tools.translator.bytecodes.TryCatch.appendInstruction(StringBuilder, List) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - Normal: com/codename1/tools/translator/ByteCodeClass.java:1791 – com.codename1.tools.translator.ByteCodeClass.getBaseClassObject() may expose internal representation by returning ByteCodeClass.baseClassObject (rule: EI_EXPOSE_REP)
    - …and 94 more
- ❌ android: 412 findings (High: 24, Normal: 196, Low: 192)
  - Top findings
    - High: CodenameOne/src/com/codename1/impl/CodenameOneThread.java:48 – com.codename1.impl.CodenameOneThread.STACK_FRAME_SIZE isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - High: com/codename1/impl/android/AndroidImplementation.java:1066 – Write to static field com.codename1.impl.android.AndroidImplementation.context from instance method com.codename1.impl.android.AndroidImplementation.setContext(Context) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - High: com/codename1/impl/android/AndroidImplementation.java:1267 – com.codename1.impl.android.AndroidImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
    - …and 409 more
- ❌ codenameone-maven-plugin: 480 findings (High: 1, Normal: 316, Low: 163)
  - Top findings
    - High: com/codename1/maven/AbstractCN1Mojo.java:807 – com.codename1.maven.AbstractCN1Mojo.OS isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - Normal: com/codename1/builders/AndroidGradleBuilder.java:1018 – Dead store to googleServicesJson in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) (rule: DLS_DEAD_LOCAL_STORE)
    - Normal: com/codename1/builders/AndroidGradleBuilder.java:1043 – Possible null pointer dereference in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) due to return value of called method (rule: NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE)
    - …and 477 more
- ✅ core-unittests: 0 findings (no issues)
- ❌ ios: 125 findings (High: 4, Normal: 75, Low: 46)
  - Top findings
    - High: com/codename1/impl/ios/IOSImplementation.java:1222 – com.codename1.impl.ios.IOSImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
    - High: com/codename1/impl/ios/IOSImplementation.java:128 – com.codename1.impl.ios.IOSImplementation.nativeInstance isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    - High: com/codename1/impl/ios/IOSImplementation.java:213 – Write to static field com.codename1.impl.ios.IOSImplementation.instance from instance method com.codename1.impl.ios.IOSImplementation.init(Object) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
    - …and 122 more
✅ PMD: 0 findings (no issues) [Report archive]
✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

… always on the EDT

Refine sheet hit tests and expand screenshot

5c87623

shai-almog added the codex label Feb 9, 2026 — with ChatGPT Codex Connector

Suppress PMD volatile warning for Sheet bounds

56bbf3e

shai-almog added 5 commits February 9, 2026 18:44

Use per-sheet bounds rectangles for hit testing

e895ea6

Simplify sheet bounds tracking list

0813f02

Added new android screenshot

376d9a1

Added new iOS screenshot

2c753d9

Fixed PMD silly warnings and removed redundant lock since mutation is…

bad3596

… always on the EDT

shai-almog merged commit 72a67bb into master Feb 10, 2026
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refine Sheet hit-test ordering and expand Sheet screenshot test#4505

Refine Sheet hit-test ordering and expand Sheet screenshot test#4505
shai-almog merged 7 commits intomasterfrom
codex/add-special-case-for-sheet-component-events

shai-almog commented Feb 9, 2026

Uh oh!

shai-almog commented Feb 9, 2026 •

edited

Loading

Uh oh!

shai-almog commented Feb 9, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

Conversation

shai-almog commented Feb 9, 2026

Motivation

Description

Testing

Uh oh!

shai-almog commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Native Android coverage

Uh oh!

shai-almog commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmark Results

Detailed Performance Metrics

Uh oh!

github-actions bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

shai-almog commented Feb 9, 2026 •

edited

Loading

shai-almog commented Feb 9, 2026 •

edited

Loading

github-actions bot commented Feb 9, 2026 •

edited

Loading